Address regression introduced with PyDSDL v1.14 #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-kirienko
force-pushed
the
pydsdl-fix
branch
from
3d6cb58
to
9fed601
Compare
|
I'm not okay with removing Python 3.6 support. Is that a requirement for this change? |
|
I can go back and restore Python 3.6 support in PyDSDL but what do we need that for? |
An ability to retrofit existing systems. |
|
Kudos, SonarCloud Quality Gate passed! |
|
@thirtytwobits support for Python 3.6 is back |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was reported this morning by @PonomarevDA
The PyDSDL v1.14 changeset is here: OpenCyphal/pydsdl#77
The PyDSDL v1.15 changeset is here: OpenCyphal/pydsdl#80
I also removed Python 3.6 from the classifiers but this does not address the root of the problem, which is that we have the same information listed in several places, and it is certain that inconsistencies will occasionally emerge. I suggest removing the list of Python versions from the classifiers.