Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scene labeling option that provides the VLM its label history #1661

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

ashayathalye
Copy link
Collaborator

No description provided.

@ashayathalye ashayathalye marked this pull request as ready for review May 31, 2024 19:21
@ashayathalye ashayathalye changed the title Add scene labeling option that provides the VLM with label history Add scene labeling option that provides the VLM its label history May 31, 2024
Copy link
Member

@NishanthJKumar NishanthJKumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very clean and nice implementation; great work! 🎉 Only one minor comment

@@ -641,6 +651,7 @@ def _query_vlm_to_generate_ground_atoms_trajs(
else: # pragma: no cover.
atom_proposals_set = env.get_vlm_debug_atom_strs(train_tasks)
assert len(atom_proposals_set) > 0, "Atom proposals set is empty!"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: revert this newline

@ashayathalye ashayathalye merged commit 9b4490c into master Jun 3, 2024
6 checks passed
@ashayathalye ashayathalye deleted the give-vlm-labeling-history branch June 3, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants