Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix duplicated pinned clipboard entries #680

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

codokie
Copy link
Contributor

@codokie codokie commented Apr 11, 2024

fixes #616

@Helium314
Copy link
Owner

Thanks!

@Helium314 Helium314 merged commit 19c22dd into Helium314:main Apr 15, 2024
1 check passed
@Uranusek
Copy link

Thanks for fixing this. Unfortunately, there is still a problem with items temporarily disappearing from the clipboard after changing the keyboard.

To reproduce

  1. Change the keyboard
  2. Return to HeliBoard
  3. Open the clipboard
  4. Wait a moment
  5. See items disappeared (even pinned)

The items appear when you reopen the clipboard and the problem no longer occurs. Well, unless you change the keyboard again.

@codokie
Copy link
Contributor Author

codokie commented Apr 20, 2024

@Uranusek are u using the current beta or have u compiled a debug APK from source?
could you open an issue for it please with a video reproducing the bug?

@Uranusek
Copy link

are u using the current beta or have u compiled a debug APK from source?

First the compiled debug APK, and now version 1.3 and the problem still occurs.

could you open an issue for it please with a video reproducing the bug?

Sure, although I already reported it #616 There is also a video showing this bug. If necessary, I will open a new issue.

@codokie
Copy link
Contributor Author

codokie commented Apr 20, 2024

Ah I did not notice the video, for some reason Github collapsed it
I have found what is causing this issue and will open a PR shortly
you could reopen #616 since one of the issues there has not been fixed yet (maybe change the title if you do)

@Uranusek
Copy link

I can't find an option to reopen the issue. Maybe only @Helium314 can do it.

@codokie codokie deleted the duplicated-history branch April 26, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinned items in the clipboard are duplicated
3 participants