Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned items in the clipboard are duplicated #616

Closed
Uranusek opened this issue Apr 1, 2024 · 3 comments · Fixed by #680
Closed

Pinned items in the clipboard are duplicated #616

Uranusek opened this issue Apr 1, 2024 · 3 comments · Fixed by #680
Labels
bug Something isn't working

Comments

@Uranusek
Copy link

Uranusek commented Apr 1, 2024

Describe the bug
Pinned items duplicate when you change the keyboard.

To Reproduce

  1. Copy something
  2. Pin it
  3. Change the keyboard and return to HeliBoard
  4. Notice that the pinned item has been duplicated

Expected behavior
Pinned items are not duplicated

Screenshots

screen-20240401-195831_1_1.mp4
screen-20240401-195831_1_1bh.mp4

App version
HeliBoard 1.0. I will check if the bug is present in the previous version, but I doubt it, because I would have noticed.

Device (please complete the following information):

  • Model: Motorola
  • OS: Android 11

Additional context
Generally with the clipboard something strange is happening. You can see in the video. Elements seem to disappear, but immediately reappear.
Moments earlier, the pinned items could not be unpinned and only forcing the keyboard to close helped. Now I can't reproduce it.

@Uranusek Uranusek added the bug Something isn't working label Apr 1, 2024
@codokie
Copy link
Contributor

codokie commented Apr 1, 2024

#611 I believe this should prevent the duplication, although in ClipboardHistoryManager, I think the historyEntries should not be a companion object?
It survives a keyboard change all right, but onCreate() calls loadPinnedClips() which essentially adds duplicates.

@codokie
Copy link
Contributor

codokie commented Apr 1, 2024

Actually if historyEntries is not a companion object, a keyboard change would destroy all non-pinned items which is probably not warranted for.
So not adding anything if the history is not empty would be more efficient 0992bbc

@iamgitcat
Copy link

This bug is really annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants