Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Zygote to 0.4.20 #1161

Closed
wants to merge 3 commits into from
Closed

Bump Zygote to 0.4.20 #1161

wants to merge 3 commits into from

Conversation

aminya
Copy link
Contributor

@aminya aminya commented May 5, 2020

No description provided.

@DhairyaLGandhi
Copy link
Member

Let's drop the patch maybe

@aminya
Copy link
Contributor Author

aminya commented May 5, 2020

@dhairyagandhi96 is there a reason to use Manifest.toml on master? This breaks backward compatibility for older Julia versions, and it is highly recommended against.

@DhairyaLGandhi
Copy link
Member

There's some discussion here FluxML/Zygote.jl#629 (comment)

@DhairyaLGandhi
Copy link
Member

DhairyaLGandhi commented May 19, 2020

Can we fix the conflicts with manifest?

@aminya
Copy link
Contributor Author

aminya commented May 19, 2020

Remove the Manifest from the master. Then you can merge this.
#1164

@CarloLucibello
Copy link
Member

not needed anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants