Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Manifest from master #1164

Closed
aminya opened this issue May 5, 2020 · 1 comment
Closed

Remove Manifest from master #1164

aminya opened this issue May 5, 2020 · 1 comment

Comments

@aminya
Copy link
Contributor

aminya commented May 5, 2020

Using Manifest breaks backward compatibility, and it is a bad practice to add it to the master. You should allow Pkg to generate Manifest. By checking Manifest, you will bypass all of Pkg goodness across different users and Julia versions.

You should instead use compat entry for limiting the package bounds.

PackageX = "0.4, 1"

For example by using Manifest, If a dep starts to use a Jil package, all of the Julia versions older than 1.3 will break.

[[IntelOpenMP_jll]]
deps = ["Libdl", "Pkg"]
git-tree-sha1 = "fb8e1c7a5594ba56f9011310790e03b5384998d6"
uuid = "1d5cc7b8-4909-519e-a0f8-d0f5ad9712d0"
version = "2018.0.3+0"

related FluxML/Zygote.jl#629

@aminya
Copy link
Contributor Author

aminya commented Jun 14, 2020

@MikeInnes @CarloLucibello @dhairyagandhi96 This is not fixed yet. Not sure why it is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants