Managed identity support #1942
Merged
Managed identity support #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
approved these changes
Nov 1, 2021
Comment on lines
13
to
15
| To use Service Principal authentication, specify an `aso-controller-settings` secret with `AZURE_CLIENT_SECRET` set. | ||
| `AZURE_CLIENT_ID` must be set to the Service Principal client ID. | ||
| `AZURE_CLIENT_SECRET` must be set to the Service Principal client secret. |
There was a problem hiding this comment.
Suggested change
| To use Service Principal authentication, specify an `aso-controller-settings` secret with `AZURE_CLIENT_SECRET` set. | |
| `AZURE_CLIENT_ID` must be set to the Service Principal client ID. | |
| `AZURE_CLIENT_SECRET` must be set to the Service Principal client secret. | |
| To use Service Principal authentication, specify an `aso-controller-settings` secret with `AZURE_CLIENT_ID` and `AZURE_CLIENT_SECRET` set. | |
| * `AZURE_CLIENT_ID` must be set to the Service Principal client ID. | |
| * `AZURE_CLIENT_SECRET` must be set to the Service Principal client secret. |
Maybe give an example of each, so that people can recognize when they've found the right value to include?
There was a problem hiding this comment.
Giving an example here is a bit awkward because both fields are pretty inscrutable (CLIENT_ID is a GUID and the password is some black-box base64'ed string that Azure gives to them when they create the SP). What I've done is call out that client ID is a GUID and also link to the documentation in the Azure CLI that shows how to create an SP (which will return these values).
matthchr
force-pushed
the
feature/managed-identity
branch
from
6da2dd7
to
061cacb
Compare
matthchr
force-pushed
the
feature/managed-identity
branch
from
061cacb
to
e1abcd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1869
Closes #1854
What this PR does / why we need it:
Adds Managed Identity support and documents how to use it. Testing is still an outstanding issue which we need to solve.
See #1941. I will be following up with a separate PR for this.
If applicable: