Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that AAD Pod Identity integration in ASOv2 works well #1854

Closed
matthchr opened this issue Oct 5, 2021 · 0 comments · Fixed by #1942
Closed

Ensure that AAD Pod Identity integration in ASOv2 works well #1854

matthchr opened this issue Oct 5, 2021 · 0 comments · Fixed by #1942

Comments

@matthchr
Copy link
Member

matthchr commented Oct 5, 2021

Describe the current behavior
ASOv1 has an AAD Pod Identity binding named aso_manager_binding.

Describe the improvement
aso_manager_binding is a fine name when using AAD Pod Identity through its Helm installation, but when using it through the AKS addon, the name of the binding is by default the value used in the selector, which is aso_manager_binding, but since _'s are not allowed in Kubernetes resource names, that causes issues.

We should instead use a selector for ASO v2 that doesn't contain underscores (aso-manager-binding) or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants