Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor remaining deprecated Ember code #250

Merged
merged 10 commits into from
Nov 25, 2021
Merged

Refactor remaining deprecated Ember code #250

merged 10 commits into from
Nov 25, 2021

Commits on Nov 25, 2021

  1. Use native JS class for router service stub

    @galfert
    galfert committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    cfc1f7d View commit details
    Browse the repository at this point in the history

  2. Remove side effects from DateHeadline computed property

    @galfert
    galfert committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    021ea21 View commit details
    Browse the repository at this point in the history

  3. Remove use of computed properties in native classes 

    Replace computed properties with getter methods and, where appropriate,
use the @cached decorator. See
https://emberjs.github.io/rfcs/0566-memo-decorator.html for
documentation of the decorator.
    @galfert
    galfert committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    f894c27 View commit details
    Browse the repository at this point in the history

  4. Move menu action from route to controller 

    Routes are not supposed to access the controller from actions.
    @galfert
    galfert committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    6c73876 View commit details
    Browse the repository at this point in the history

  5. Remove usage of route-action-helper 

    Don't rely on actions bubbling up the route hierarchy anymore. Instead they should be passed as explicit method references.
    @galfert
    galfert committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    ac1609d View commit details
    Browse the repository at this point in the history

  6. Remove controller access from route 

    Accessing the controller from the route outside of setupController/resetController is discouraged.
    @galfert
    galfert committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    ae95824 View commit details
    Browse the repository at this point in the history

  7. Add autocomplete attributes to account input fields 

    This helps with password managers.
    @galfert
    galfert committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    6faee72 View commit details
    Browse the repository at this point in the history

  8. Fix linter warning about inputs having multiple labels 

    input fields with an `id` and `aria-label` attribute trigger a linter warning
    @galfert
    galfert committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    f9785f2 View commit details
    Browse the repository at this point in the history

  9. Remove custom eslint configs for ember rules 

    All linter warnings have been fixed, so we can just use ember/recommended again.
    @galfert
    galfert committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    0044a35 View commit details
    Browse the repository at this point in the history

  10. Small function refactoring

    @raucao
    raucao committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    c1d2fb3 View commit details
    Browse the repository at this point in the history