Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor remaining deprecated Ember code #250

Merged
merged 10 commits into from
Nov 25, 2021
Merged

Refactor remaining deprecated Ember code #250

merged 10 commits into from
Nov 25, 2021

Conversation

galfert
Copy link
Contributor

@galfert galfert commented Nov 25, 2021

This fixes all remaining linter warnings.

@galfert
Use native JS class for router service stub
cfc1f7d
@galfert
Remove side effects from DateHeadline computed property
021ea21
@galfert
Remove use of computed properties in native classes
f894c27 
Replace computed properties with getter methods and, where appropriate,
use the @cached decorator. See
https://emberjs.github.io/rfcs/0566-memo-decorator.html for
documentation of the decorator.
@galfert
Move menu action from route to controller
6c73876 
Routes are not supposed to access the controller from actions.
@galfert
Remove usage of route-action-helper
ac1609d 
Don't rely on actions bubbling up the route hierarchy anymore. Instead they should be passed as explicit method references.
@galfert
Remove controller access from route
ae95824 
Accessing the controller from the route outside of setupController/resetController is discouraged.
@galfert
Add autocomplete attributes to account input fields
6faee72 
This helps with password managers.
@galfert
Fix linter warning about inputs having multiple labels
f9785f2 
input fields with an `id` and `aria-label` attribute trigger a linter warning
@galfert
Remove custom eslint configs for ember rules
0044a35 
All linter warnings have been fixed, so we can just use ember/recommended again.
@galfert galfert requested a review from raucao November 25, 2021 17:30
raucao
raucao approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@raucao raucao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! 👏 🎉

I pushed a small commit to fix the CodeClimate warning. No attribution necessary.

@raucao raucao changed the title Fix linter warnings/errors Refactor remaining deprecated Ember code Nov 25, 2021
@raucao raucao merged commit bd70185 into master Nov 25, 2021
@raucao raucao deleted the feature/fix_linter_errors branch November 25, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raucao raucao raucao approved these changes

Assignees
No one assigned
Labels
kredits-2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galfert @raucao