Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package dependencies to support php 7.4 #35

Merged
merged 11 commits into from
Aug 28, 2020

Conversation

zrashwani
Copy link
Owner

@zrashwani zrashwani commented Aug 9, 2020

  • Major dependencies update to support php 7.4
  • Replace illuminate/support package with tightenco/collect to provide collections with minimal dependency
  • Amending unit tests and Travis settings to prevent chromedriver version error

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2020

Codecov Report

Merging #35 into master will decrease coverage by 1.20%.
The diff coverage is 95.83%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #35      +/-   ##
============================================
- Coverage     96.24%   95.04%   -1.21%     
+ Complexity      140      118      -22     
============================================
  Files             6        6              
  Lines           373      343      -30     
============================================
- Hits            359      326      -33     
- Misses           14       17       +3     
Impacted Files Coverage Δ Complexity Δ
src/Arachnid/Crawler.php 92.13% <93.85%> (-1.24%) 51.00 <36.00> (-10.00)
src/Arachnid/Link.php 96.93% <97.91%> (-1.40%) 48.00 <34.00> (-6.00)
src/Arachnid/Adapters/CrawlingFactory.php 100.00% <100.00%> (ø) 5.00 <5.00> (+2.00)
src/Arachnid/Adapters/GoutteAdapter.php 100.00% <100.00%> (ø) 3.00 <3.00> (-1.00)
src/Arachnid/Adapters/PantherChromeAdapter.php 100.00% <100.00%> (ø) 3.00 <3.00> (ø)
src/Arachnid/LinksCollection.php 100.00% <100.00%> (ø) 8.00 <8.00> (-7.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97ddfa8...7c3766a. Read the comment docs.

@zrashwani zrashwani merged commit 4614d28 into master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants