minizip.pc: Ensure variables point to an absolute path. #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Idk why but it says it needs rebased. I tried to fix it but it didn't work. If you can squash and rebase everything thanks. Sorry I didn't get to your PR first. |
With commit 503bfd5 the CMake _IMPORT_PREFIX has been changed to relative paths. This breaks the paths reflected by the auto-generated pkgconfig file, as pkgconfig expects those paths to be absolute. Signed-off-by: Björn Esser <[email protected]>
besser82
force-pushed
the
topic/besser82/fix_pkgconfig
branch
from
8c4c01f
to
c6551d3
Compare
No problem! I've rebased my commit onto the dev branch, and it looks like the previously merged PR has not covered the needed fix to |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With commit 503bfd5 the CMake
_IMPORT_PREFIXhas been changed to relative paths. This breaks the paths reflected by the auto-generated pkgconfig file, as pkgconfig expects those paths to be absolute.Closes #584.