Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test executable doesn’t build in version 3 #560

Closed
vitekcerny opened this issue Mar 7, 2021 · 2 comments
Closed

Test executable doesn’t build in version 3 #560

vitekcerny opened this issue Mar 7, 2021 · 2 comments

Comments

@vitekcerny
Copy link

Hi, I’m using minizip for simple decompression of zip file on windows. My build configuration is as follows: cmake -B build -A Win32 -D MZ_COMPAT=OFF -D MZ_BZIP2=OFF -D MZ_LZMA=OFF -D MZ_ZSTD=OFF -D MZ_PKCRYPT=OFF -D MZ_WZAES=OFF -D MZ_SIGNING=OFF -D MZ_ICONV=OFF -D MZ_DECOMPRESS_ONLY=ON -D MZ_BUILD_TESTS=ON
And I build using: cmake --build build --config Release --parallel

This was working fine previously, but starting with version 3 I get several link errors of unresolved external symbol _mz_crypt_xxx. A workaround is to enable signing by simply remove the flag -D MZ_SIGNING=OFF. This seems to work but I still think that signing support should be optional.

nmoinvaz added a commit that referenced this issue Apr 11, 2021
@nmoinvaz
Copy link
Member

Should be fixed in dev. Thanks for reporting.

@vitekcerny
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants