Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.7.3: Store only is not compatible with 7-zip/macOS #352

Closed
bcse opened this issue Nov 30, 2018 · 2 comments
Closed

2.7.3: Store only is not compatible with 7-zip/macOS #352

bcse opened this issue Nov 30, 2018 · 2 comments
Labels
fixed Issue or bug has been fixed raw Raw file storage

Comments

@bcse
Copy link

bcse commented Nov 30, 2018

Here's what I've done.

  1. Download minizip 2.8.0 release.

  2. Build with cmake

cmake . -DBUILD_TEST=ON
cmake --build .
  1. Create a store only zip
./minizip -0 store_only.zip test
  1. Create a compressed zip
./minizip -9 best_compression.zip test
  1. The store_only.zip can't be correctly extracted by 7-zip or macOS built-in archiver. But best_compression.zip works fine. And store_only.zip can be extracted with minizip itself.

--

Here is the result of ./minizip -l store_only.zip

Minizip 2.8.0 - https://github.com/nmoinvaz/minizip
---------------------------------------------------
-l store_only.zip
      Packed     Unpacked Ratio Method   Attribs Date     Time  CRC-32     Name
      ------     -------- ----- ------   ------- ----     ----  ------     ----
           0            0    0% Stored  81a40080 11-25-18 09:59 00000000   empty.txt
        1988            0    0% Stored  81a40080 11-25-18 09:59 26cb60bd   ia.crt
        2114            0    0% Stored  81a40080 11-25-18 09:59 fe5f5542   ca.crt
         570            0    0% Stored  81a40080 11-25-18 09:59 a1cac1c6   test.h
        5749            0    0% Stored  81a40080 11-25-18 09:59 f6dcf032   ia.p12
...

And here is the result of ./minizip -l test.zip
test.zip is created by 7-zip with store only setting.

Minizip 2.8.0 - https://github.com/nmoinvaz/minizip
---------------------------------------------------
-l test.zip
      Packed     Unpacked Ratio Method   Attribs Date     Time  CRC-32     Name
      ------     -------- ----- ------   ------- ----     ----  ------     ----
        2114         2114  100% Stored  81a48020 11-25-18 09:59 fe5f5542   ca.crt
        3243         3243  100% Stored  81a48020 11-25-18 09:59 f5027753   ca.key
        2114         2114  100% Stored  81a48020 11-25-18 09:59 fe5f5542   cacert.pem
           0            0    0% Stored  81a48020 11-25-18 09:59 00000000   empty.txt
           0            0    0% Stored  41ed8010 11-25-18 09:59 00000000   fuzz/
...

Isn't it abnormal that store_only.zip's unpacked size is 0?

@bcse
Copy link
Author

bcse commented Nov 30, 2018

P.S. 2.7.2 is the latest compatible version. 2.7.3 introduces this issue.

@bcse bcse changed the title Store only is not compatible with 7-zip/macOS 2.7.3: Store only is not compatible with 7-zip/macOS Nov 30, 2018
@nmoinvaz
Copy link
Member

nmoinvaz commented Dec 1, 2018

That should be fixed now in dev. Thanks for reporting it.

@nmoinvaz nmoinvaz closed this as completed Dec 1, 2018
@nmoinvaz nmoinvaz added 2.0 fixed Issue or bug has been fixed raw Raw file storage labels Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Issue or bug has been fixed raw Raw file storage
Projects
None yet
Development

No branches or pull requests

2 participants