Skip to content

Commit

Permalink
api, metadata: use map type for Container.Extensions
Browse files Browse the repository at this point in the history
To allow for updating extensions without collisions, we have moved to
using a map type that can be explicitly selected via the field path for
updates. This ensures that multiple parties can operate on their
extensions without stepping on each other's toes or incurring an
inordinate number of round trips.

Signed-off-by: Stephen J Day <[email protected]>
  • Loading branch information
stevvooe committed Sep 9, 2017
1 parent 3552ce5 commit f7d31e2
Show file tree
Hide file tree
Showing 9 changed files with 349 additions and 123 deletions.
23 changes: 22 additions & 1 deletion api/next.pb.txt
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ file {
number: 10
label: LABEL_REPEATED
type: TYPE_MESSAGE
type_name: ".google.protobuf.Any"
type_name: ".containerd.services.containers.v1.Container.ExtensionsEntry"
options {
65001: 0
}
Expand Down Expand Up @@ -234,6 +234,27 @@ file {
json_name: "options"
}
}
nested_type {
name: "ExtensionsEntry"
field {
name: "key"
number: 1
label: LABEL_OPTIONAL
type: TYPE_STRING
json_name: "key"
}
field {
name: "value"
number: 2
label: LABEL_OPTIONAL
type: TYPE_MESSAGE
type_name: ".google.protobuf.Any"
json_name: "value"
}
options {
map_entry: true
}
}
}
message_type {
name: "GetContainerRequest"
Expand Down
Loading

0 comments on commit f7d31e2

Please sign in to comment.