Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mips: fix endianess issues #197

Merged
merged 1 commit into from
Sep 11, 2023
Merged

mips: fix endianess issues #197

merged 1 commit into from
Sep 11, 2023

Conversation

carenas
Copy link
Contributor

@carenas carenas commented Aug 31, 2023

Addresses the remaining issues shown in little endian systems:

carenasgm@gcc23:~/src/sljit$ bin/sljit_test
Pass -v to enable verbose, -s to disable this hint.

test58 case 1 failed
test59 case 5 failed
test77 case 7 failed
test79 case 21 failed
SLJIT tests: 4 (3%) tests FAILED on MIPS III 32bit (little endian + aligned) (with fpu)

@carenas carenas marked this pull request as draft September 7, 2023 19:56
@carenas carenas marked this pull request as ready for review September 10, 2023 21:15
@zherczeg
Copy link
Owner

Is this patch done?

@carenas
Copy link
Contributor Author

carenas commented Sep 11, 2023

Is this patch done?

yes; I would mark it as draft if it was still being worked on, or have not been tested.

but somehow the previous push (which was done after testing and which I thought was final) had a typo introduced which required an update, several hours later.

at least it was caught earlier, but IMHO this would be a good reason why some sort of CI would be useful.

Copy link
Owner

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zherczeg zherczeg merged commit 03d4001 into zherczeg:master Sep 11, 2023
@carenas carenas deleted the yamipsel branch September 11, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants