config: remove SLJIT_EXEC_OFFSET from list of required macros for an external allocator #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
reviewed
Nov 30, 2022
SLJIT_EXEC_OFFSET is a definition that is only implemented internally by the allocator selected with SLJIT_PROT_EXECUTABLE_ALLOCATOR. Expand the fallback definition also for cases when an external allocator is in use, to simplify the interface, but continue using it if already defined, for backward compatibility.
zherczeg
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it is only required as part of "protexec", it shouldn't need to be provided also by external allocators.
Expand the fallback definition, so that the only two macros that are required are the ones that point to the external functions to allocate and free executable memory.
Keep using one if it is already provided for backward compatibility.