Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riscv: avoid SIGILL in 64bit while jumping #140

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

carenas
Copy link
Contributor

@carenas carenas commented Nov 29, 2022

breaking test15 consistently when building against both available riscv nodes in the GCC compiler farm[1]

[1] https://cfarm.tetaneutral.net/machines/list/#

affecting 64bit when a jump was coded with 4 instructions, leaving
one extra invalid instruction that would trigger SIGILL.
Copy link
Owner

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zherczeg
Copy link
Owner

Nice catch! Are these machines freely available for testing code?

@zherczeg zherczeg merged commit f55425d into zherczeg:master Nov 29, 2022
@carenas
Copy link
Contributor Author

carenas commented Nov 29, 2022

Are these machines freely available for testing code?

need to request for an account first, but they are meant for opensource development :

https://cfarm.tetaneutral.net/users/new/

@carenas carenas deleted the upstream branch November 29, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants