-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove permission interface #16
Conversation
There are two typecasts in the default role implementation:
should they be kept, now that the permissioninterface is gone? |
I'd prefer to keep them. They make sure that numbers are cast to string to (though naming permissions with number would be a bit strange :d) |
And it would allow someone using ZfcRbac to still be able to use those built-in classes. |
Maybe do something like /**
* {@inheritDoc}
*/
public function hasPermission($permission)
{
if (!is_string($perimssion)) {
throw new InvalidArgumentException;
}
return isset($this->permissions[$permission]);
} ? |
But sure, I'm fine with keeping them. Just wanted to ask to see if you missed this |
I'm merging. I don't know what to include now into this library. @arekkas , the CARBAC feature would actually something that would be here or in ZfcRbac? |
Yes absolutely :) |
Absolutely what? |
CaRBAC is something for directly here or ZfcRbac |
ping @danizord @jmleroux @arekkas
Any other idea about what we could do?