Use undefined for default parameters

zenorocha · Sep 30, 2015 · 902c730 · 902c730
1 parent 14baab7
commit 902c730
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/clipboard.js b/src/clipboard.js
@@ -39,7 +39,8 @@ class Clipboard extends Emitter {
      * @param {Element} trigger
      */
     setAction(trigger) {
-        return trigger.getAttribute(prefix + 'action');
+        var action = trigger.getAttribute(prefix + 'action');
+        return action === null ? undefined : action;
     }
 
     /**

diff --git a/test/clipboard-action.js b/test/clipboard-action.js
@@ -36,7 +36,7 @@ describe('ClipboardAction', () => {
         it('should throw an error since neither "text" nor "target" were passed', done => {
             try {
                 new ClipboardAction({
-                    action: ''
+                    action: undefined
                 });
             }
             catch(e) {