Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct description http header rule #912

Merged
merged 3 commits into from
Jan 9, 2019
Merged

Use correct description http header rule #912

merged 3 commits into from
Jan 9, 2019

Conversation

maxim-tschumak
Copy link
Contributor

Replaces #905

@maxim-tschumak maxim-tschumak mentioned this pull request Jan 9, 2019
Closed
@tkrop
Copy link
Member

tkrop commented Jan 9, 2019

👍

@codecov-io
Copy link

codecov-io commented Jan 9, 2019 •
edited
Loading

Codecov Report

Merging #912 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #912   +/-   ##
=========================================
  Coverage     84.56%   84.56%           
  Complexity      908      908           
=========================================
  Files           175      175           
  Lines          2747     2747           
  Branches        438      438           
=========================================
  Hits           2323     2323           
  Misses          203      203           
  Partials        221      221
Impacted Files Coverage Δ Complexity Δ
...do/zally/rule/zalando/PascalCaseHttpHeadersRule.kt 100% <100%> (ø) 3 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2212ac1...45cff79. Read the comment docs.

@maxim-tschumak
Copy link
Contributor Author

👍

@maxim-tschumak maxim-tschumak merged commit d7546fe into master Jan 9, 2019
@maxim-tschumak maxim-tschumak deleted the use-correct-description-http-header-rule branch January 9, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkrop tkrop tkrop approved these changes

@netme netme Awaiting requested review from netme

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxim-tschumak @tkrop @codecov-io @ech0s7r