Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(server): Dropped RegexCustomType in favour of upstream Regex support #894

Closed

Conversation

roxspring
Copy link
Collaborator

Closes #893

@codecov-io
Copy link

codecov-io commented Nov 7, 2018

Codecov Report

Merging #894 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #894      +/-   ##
============================================
+ Coverage     84.23%   84.27%   +0.03%     
+ Complexity      885      882       -3     
============================================
  Files           174      173       -1     
  Lines          2684     2678       -6     
  Branches        427      426       -1     
============================================
- Hits           2261     2257       -4     
+ Misses          205      203       -2     
  Partials        218      218
Impacted Files Coverage Δ Complexity Δ
...do/zally/configuration/RulesConfigConfiguration.kt 50% <ø> (-16.67%) 2 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 331bdfe...454e6cd. Read the comment docs.

@maxim-tschumak
Copy link
Contributor

👍

@ghost
Copy link

ghost commented Nov 8, 2018

👍

@tkrop
Copy link
Member

tkrop commented Nov 12, 2018

👍

@roxspring roxspring force-pushed the feature/gh-893-config4k-upgrade branch from a256e35 to ef07065 Compare November 12, 2018 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants