Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change OpenAPI.getAllParameters() helper function #1333

Merged
merged 2 commits into from
Oct 28, 2021

Conversation

vadeg
Copy link
Contributor

@vadeg vadeg commented Oct 26, 2021

  • Change return type in OpenAPI.getAllParameters() from Map<String, Parameter> to Collection<Parameter>
  • Update dependent rules

Fixes #1317

…ection

* Change return type in `OpenAPI.getAllParameters()`
* Update dependent rules
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2021

Codecov Report

Merging #1333 (e1cd02d) into master (f00c85c) will decrease coverage by 0.03%.
The diff coverage is 63.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1333      +/-   ##
============================================
- Coverage     75.05%   75.01%   -0.04%     
+ Complexity      932      931       -1     
============================================
  Files           167      167              
  Lines          2682     2682              
  Branches        492      492              
============================================
- Hits           2013     2012       -1     
  Misses          410      410              
- Partials        259      260       +1     
Impacted Files Coverage Δ
.../main/kotlin/org/zalando/zally/core/CaseChecker.kt 28.67% <0.00%> (ø)
.../kotlin/org/zalando/zally/core/util/OpenApiUtil.kt 49.41% <25.00%> (-1.18%) ⬇️
...eset/zalando/QueryParameterCollectionFormatRule.kt 77.77% <100.00%> (ø)
...g/zalando/zally/ruleset/zally/PathParameterRule.kt 75.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f00c85c...e1cd02d. Read the comment docs.

@vadeg
Copy link
Contributor Author

vadeg commented Oct 27, 2021

👍

1 similar comment
@tkrop
Copy link
Member

tkrop commented Oct 28, 2021

👍

@tkrop
Copy link
Member

tkrop commented Oct 28, 2021

Strange that the coverage is shrinking while this should be a none-change.

@tkrop tkrop merged commit 32213af into master Oct 28, 2021
@tkrop tkrop deleted the gh-1317-replace-function branch October 28, 2021 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with the retrieval of all the parameters of the OpenAPI
3 participants