Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Custom Rule Creation documentation #1337

Closed
beena-yatin-kanyal opened this issue Nov 12, 2021 · 3 comments · Fixed by #1346
Closed

Update the Custom Rule Creation documentation #1337

beena-yatin-kanyal opened this issue Nov 12, 2021 · 3 comments · Fixed by #1346

Comments

@beena-yatin-kanyal
Copy link

In the documentation available at this link, the imports listed at this are not available in the Zally code anymore. Please update the documentation so that readers can correctly understand and work to create better documentation as per the organization.

import de.zalando.zally.rule.api.Check
import de.zalando.zally.rule.api.Context
import de.zalando.zally.rule.api.Rule
import de.zalando.zally.rule.api.Severity
import de.zalando.zally.rule.api.Violation

Thanks.

@ePaul
Copy link
Member

ePaul commented Dec 23, 2021

Those classes are now in package org.zalando.zally.rule.api (instead of de.*).

@beena-yatin-kanyal
Copy link
Author

Thanks. closing this issue.

A recommendation is to please update the documentation.

@ePaul
Copy link
Member

ePaul commented Dec 26, 2021

I'm reopening the issue for updating the documentation. (Feel free to open a PR.)

@ePaul ePaul reopened this Dec 26, 2021
vadeg added a commit that referenced this issue Jan 14, 2022
…n-docs

feat: update rule creation docs with org.zalando (#1337)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants