Skip to content

Commit

Permalink
scripts/checkpatch.pl: __GFP_NOFAIL isn't going away
Browse files Browse the repository at this point in the history
Revert commit 7e4915e ("checkpatch: add warning of future
__GFP_NOFAIL use").

There are no plans to remove __GFP_NOFAIL.

__GFP_NOFAIL exists to

a) centralise the retry-allocation-for-ever operation into the core
   allocator, which is the appropriate implementation site and

b) permit us to identify code sites which aren't handling memory
   exhaustion appropriately.

Cc: David Rientjes <[email protected]>
Cc: Joe Perches <[email protected]>
Cc: Theodore Ts'o <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
akpm00 authored and torvalds committed Apr 3, 2014
1 parent 3b617e3 commit 74915c7
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions scripts/checkpatch.pl
Original file line number Diff line number Diff line change
Expand Up @@ -4330,12 +4330,6 @@ sub process {
"$1 uses number as first arg, sizeof is generally wrong\n" . $herecurr);
}

# check for GFP_NOWAIT use
if ($line =~ /\b__GFP_NOFAIL\b/) {
WARN("__GFP_NOFAIL",
"Use of __GFP_NOFAIL is deprecated, no new users should be added\n" . $herecurr);
}

# check for multiple semicolons
if ($line =~ /;\s*;\s*$/) {
if (WARN("ONE_SEMICOLON",
Expand Down

0 comments on commit 74915c7

Please sign in to comment.