-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ADN extractor #31275
Fix ADN extractor #31275
Conversation
The old URL (animedigitalnetwork) can be supported by adjusting the regex but it's only thanks to a redirection and I don't know for how long this redirection will still be made. |
[ADN] Rename Anime Digital Network to Animation Digital Network. As adverted on the home page: https://animationdigitalnetwork.fr/ > Anime Digital Network se transforme en Animation Digital Network !! > Pensez à mettre à jour votre URL. That can be translated to : > Anime Digital Network is changing to Animation Digital Network! > Remember to update your URL. It's exactly what I'm doing. Signed-off-by: ache <[email protected]>
Ok, everything is fine from my side. It's ready to be merged. 🥳 3 commits, 3 fix :
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Here are some suggestions (untested).
Regex style Co-authored-by: dirkf <[email protected]>
* process HTTP error text (eg geo-block) correctly and uniformly in Py3, Py2 * but then skip test for CI since geo-blocked
Oh I'm sorry. I tried the test from France so it just worked. |
No problem, just a bit of final QA! |
* Rename Anime Digital Network to Animation Digital Network, animationdigitalnetwork.fr * Update the test to an available video * Update the decoding key of subtitles * Keep the support of old URLs * Add a test to match the old URL * Reduce redundancy of the URL name * Fix md5 ^^" * Fix undefined _BASE * Process HTTP error text (eg geo-block) correctly and uniformly in Py3, Py2 * Skip test for CI since geo-blocked Signed-off-by: ache <[email protected]> Co-authored-by: dirkf <[email protected]>
[ADN] Rename Anime Digital Network to Animation Digital Network.
As adverted on the home page: https://animationdigitalnetwork.fr/Edit: It's not advertised anymore since the 12/10.
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
It's a fix of the extractor. Everything generally work but a few thing need to be updated.
First, to use this extractor, we have to update the URL since ADN rename itself from “Anime” to “Animation”.
Initially, that wasn't the only goal of that PR. But reading the extractor tutorial and testing my code lead to two other commits.
That can be translated to :
It's exactly what I'm doing.
Fix #31273
Then, I update the test of that extractor since the video used isn't available now.
I did this change because over-wise I fear the PR will not be merged.
And finally, I found that the subtitle key used to decrypt the subtitle was old and must be updated. I did it.
PS: I also updated the test and update the key used to extract subtitle. ^^