[netease] Get netease music download url through player api #31235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkf
requested changes
Oct 10, 2022
|
@dirkf Thanks for your excellent advises, all fixed |
github-actions bot
added a commit
to hellopony/youtube-dl
that referenced
this pull request
Oct 11, 2022
* https://github.com/ytdl-org/youtube-dl: [netease] Get netease music download url through player api (ytdl-org#31235) [Common:JWPlayer] Fix x1000 scaling error [utils] Sanitize look-alike Unicode glyphs in non-ID filename fields when --restrict-filenames [JSInterp] Improve separation logic [ZDF] Overhaul ZDF extractors * pull some yt-dlp changes into ZDFBaseIE._extract_format() * add test cases from yt-dlp to ZDFIE * fix crash in ZDFIE._extract_mobile() when object had no `formitaeten` * improve title extraction in ZDFChannelIE (remove trailing station ident) * avoid extracting non-video playlist items (fixes ytdl-org#31149) [test] Implement string "lambda x: condition(x)" as an expected value [motherless] Fixed the broken uploader_id in the extractor (ytdl-org#31243)
alxlive
pushed a commit
to alxlive/youtube-dl
that referenced
this pull request
Feb 27, 2023
…#31235) * remove unplayable song from test * compatible with python 2 * using standard User_Agent, fix imports * use hash instead of long description * fix lint * fix hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Netease music downloading was broken for a long time, based on @TianyiShi2001's research #18051 (comment), I finally get the download url through player api and fixed it.
fixes #11216
fixes #11365
fixes #18051