Spelling #27084
Merged
Spelling #27084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
jsoref
commented
Nov 19, 2020
| @@ -37,7 +37,7 @@ | |||
| "writeinfojson": true, | |||
| "writesubtitles": false, | |||
| "allsubtitles": false, | |||
| "listssubtitles": false, | |||
| "listsubtitles": false, | |||
| @@ -86,7 +86,7 @@ def _real_extract(self, url): | |||
| # return self._extract_via_api(kind, video_id) | |||
|
|
|||
| # JSON api does not provide some audio formats (e.g. ogg) thus | |||
| # extractiong audio via webpage | |||
| # extracting audio via webpage | |||
There was a problem hiding this comment.
Unlike the changelog entries, this case is not extraction
| @@ -2458,7 +2458,7 @@ def __init__(self, code=None, msg='Unknown error'): | |||
|
|
|||
| # Parsing code and msg | |||
| if (self.code in (errno.ENOSPC, errno.EDQUOT) | |||
| or 'No space left' in self.msg or 'Disk quota excedded' in self.msg): | |||
| or 'No space left' in self.msg or 'Disk quota exceeded' in self.msg): | |||
There was a problem hiding this comment.
This code has moved a number of times since its introduction, but it was introduced with this spelling, and I can find no support on the internet for looking for this spelling.
I suspect it was never noticed because the preceding line is doing the real work.
There was a problem hiding this comment.
This is error message for EDQUOT.
see: https://www-numi.fnal.gov/offline_software/srt_public_context/WebDocs/Errors/unix_system_errors.html
There was a problem hiding this comment.
That matches my correction:
#define EDQUOT 122 /* Quota exceeded */
Quota exceeded, not the code as is. Thanks, that's good confirmation for this change
ThirumalaiK
pushed a commit
to ThirumalaiK/youtube-dl
that referenced
this pull request
Jan 28, 2021
* spelling: authorization Signed-off-by: Josh Soref <[email protected]> * spelling: brightcove Signed-off-by: Josh Soref <[email protected]> * spelling: creation Signed-off-by: Josh Soref <[email protected]> * spelling: exceeded Signed-off-by: Josh Soref <[email protected]> * spelling: exception Signed-off-by: Josh Soref <[email protected]> * spelling: extension Signed-off-by: Josh Soref <[email protected]> * spelling: extracting Signed-off-by: Josh Soref <[email protected]> * spelling: extraction Signed-off-by: Josh Soref <[email protected]> * spelling: frontline Signed-off-by: Josh Soref <[email protected]> * spelling: improve Signed-off-by: Josh Soref <[email protected]> * spelling: length Signed-off-by: Josh Soref <[email protected]> * spelling: listsubtitles Signed-off-by: Josh Soref <[email protected]> * spelling: multimedia Signed-off-by: Josh Soref <[email protected]> * spelling: obfuscated Signed-off-by: Josh Soref <[email protected]> * spelling: partitioning Signed-off-by: Josh Soref <[email protected]> * spelling: playlist Signed-off-by: Josh Soref <[email protected]> * spelling: playlists Signed-off-by: Josh Soref <[email protected]> * spelling: restriction Signed-off-by: Josh Soref <[email protected]> * spelling: services Signed-off-by: Josh Soref <[email protected]> * spelling: split Signed-off-by: Josh Soref <[email protected]> * spelling: srmediathek Signed-off-by: Josh Soref <[email protected]> * spelling: support Signed-off-by: Josh Soref <[email protected]> * spelling: thumbnail Signed-off-by: Josh Soref <[email protected]> * spelling: verification Signed-off-by: Josh Soref <[email protected]> * spelling: whitespaces Signed-off-by: Josh Soref <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at jsoref@d64bbf9#commitcomment-44321988
The action reports that the changes in this PR would make it happy: jsoref@5108019
Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.