[Twitch] Add support for collections as per #20414 #20604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #20414 |
|
I think you have to write that into the description to work |
|
@dstftw Can you please merge this one? |
cromefire
suggested changes
Apr 14, 2019
youtube_dl/extractor/twitch.py
Outdated
| @@ -435,6 +435,62 @@ class TwitchVideosBaseIE(TwitchPlaylistBaseIE): | |||
| _PLAYLIST_PATH = TwitchPlaylistBaseIE._PLAYLIST_PATH + '&broadcast_type=' | |||
|
|
|||
|
|
|||
| class TwitchCollectionsIE(TwitchBaseIE): | |||
| IE_NAME = 'twitch:collections' | |||
| _VALID_URL = r'%s/collections/(?P<id>[\w\d]+)' % TwitchBaseIE._VALID_URL_BASE | |||
There was a problem hiding this comment.
Twitch collection IDs can have hyphens e.g. HgTD8zFrghUb-Q, so it should be:
_VALID_URL = r'%s/collections/(?P<id>[\w\d\-]+)' % TwitchBaseIE._VALID_URL_BASE
|
Thanks |
|
I just looked through a bunch of collections and verified that this should work now |
|
Pls merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.
Trying to download a Twitch collection (example) would result in an error: the url would fall to the TwitchStream regex and it would report that 'collections' is offline as if it were a streamer. I created
TwitchCollectionsIE, a new extractor to retrieve the collection items as a playlist. Information on the Collections API can be found here.