[puhutv] Add new extractor #16269
Closed
[puhutv] Add new extractor #16269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstftw
requested changes
Apr 24, 2018
youtube_dl/extractor/puhutv.py
Outdated
|
|
||
| return { | ||
| 'id': id, | ||
| 'slug_id': video_id, |
youtube_dl/extractor/puhutv.py
Outdated
| 'description': info.get('title').get('description'), | ||
| 'uploader': info.get('title').get('producer').get('name'), | ||
| 'view_count': info.get('content').get('watch_count'), | ||
| 'follower_count': info.get('title').get('follower_count'), |
youtube_dl/extractor/puhutv.py
Outdated
| 'follower_count': info.get('title').get('follower_count'), | ||
| 'thumbnail': 'https://%s' % info.get('content').get('images').get('wide').get('main'), | ||
| 'thumbnails': thumbnails, | ||
| 'loop_thumbnails': info.get('content').get('loop_thumbnails'), |
youtube_dl/extractor/puhutv.py
Outdated
| 'uploader': info.get('title').get('producer').get('name'), | ||
| 'view_count': info.get('content').get('watch_count'), | ||
| 'follower_count': info.get('title').get('follower_count'), | ||
| 'thumbnail': 'https://%s' % info.get('content').get('images').get('wide').get('main'), |
There was a problem hiding this comment.
Read coding conventions on optional metadata and fix code appropriately.
|
I have finished all commits, Could you review again? @dstftw |
|
Optional meta fields - nothing changed. |
|
@dstftw Could you review again? If there is any problem, could you leave feedback |
dstftw
requested changes
Jun 11, 2018
youtube_dl/extractor/puhutv.py
Outdated
|
|
||
| display_id = compat_str(info['id']) | ||
| title = info['title']['name'] | ||
| if(info.get('display_name') and title is not None): |
There was a problem hiding this comment.
Outer parenthesis are superfluous. title can't be None at this point.
youtube_dl/extractor/puhutv.py
Outdated
| if(info.get('display_name') and title is not None): | ||
| title += ' ' + info.get('display_name') | ||
|
|
||
| description = info.get('title', {}).get('description') or info.get('description') |
youtube_dl/extractor/puhutv.py
Outdated
| title += ' ' + info.get('display_name') | ||
|
|
||
| description = info.get('title', {}).get('description') or info.get('description') | ||
| timestamp = parse_iso8601(info.get('created_at')) |
youtube_dl/extractor/puhutv.py
Outdated
| description = info.get('title', {}).get('description') or info.get('description') | ||
| timestamp = parse_iso8601(info.get('created_at')) | ||
| upload_date = unified_strdate(info.get('created_at')) | ||
| uploader = info.get('title', {}).get('producer', {}).get('name') |
There was a problem hiding this comment.
try_get. Same for all other places.
youtube_dl/extractor/puhutv.py
Outdated
| uploader_id = str_or_none(info.get('title', {}).get('producer', {}).get('id')) | ||
| view_count = int_or_none(info.get('content', {}).get('watch_count')) | ||
| duration = float_or_none(info.get('content', {}).get('duration_in_ms'), scale=1000) | ||
| thumbnail = urljoin('https://', info.get('content', {}).get('images', {}).get('wide', {}).get('main')) |
There was a problem hiding this comment.
First parameter to urljoin is URL.
youtube_dl/extractor/puhutv.py
Outdated
| 'https://puhutv.com/api/assets/%s/videos' % display_id, | ||
| video_id, 'Downloading video JSON', fatal=False) | ||
| if not req_formats: | ||
| self.raise_geo_restricted() |
There was a problem hiding this comment.
It does not necessarily mean that.
youtube_dl/extractor/puhutv.py
Outdated
| pagenum = 1 | ||
| has_more = True | ||
| while has_more is True: | ||
| query = { |
There was a problem hiding this comment.
Inline to actual call place.
youtube_dl/extractor/puhutv.py
Outdated
| continue | ||
| subtitles[self._SUBTITLE_LANGS.get(lang, lang)] = [{ | ||
| 'url': sub_url, | ||
| 'ext': determine_ext(sub_url) |
|
I fixed it as you requested. Would you like to have a look? @dstftw @remitamine @rg3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
New extractor added due to issue#16010