Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis test also rtmpdump videos #1601

Closed
wants to merge 1 commit into from
Closed

Travis test also rtmpdump videos #1601

wants to merge 1 commit into from

Conversation

FiloSottile
Copy link
Collaborator

Is there a reason we are not doing this? Maybe we needed #1565

If this works, I'll convert all the skip_download tests

@FiloSottile
Copy link
Collaborator Author

Ok it works but we need to check if it stable and to quiet that stuff down.

@phihag
Copy link
Contributor

phihag commented Oct 14, 2013

rtmpdump seems to hang indefinitely sometimes

@FiloSottile
Copy link
Collaborator Author

Umh, a strange line to hang on...

@jaimeMF
Copy link
Collaborator

jaimeMF commented Nov 24, 2013

I think this change is not the cause of the hang, it happens other times. If the checksum are always the same (I have yet to understand why it always download the same piece of data), I'm +1. The only problem is all the noise it produces (maybe #1680 solve this).

@FiloSottile
Copy link
Collaborator Author

Rebased to re-run, let's see...

@FiloSottile
Copy link
Collaborator Author

Test worked, Cinemassacre md5 changed, Videopremium stayed.

@jaimeMF
Copy link
Collaborator

jaimeMF commented Nov 25, 2013

rzhxeo did some improvements on the Cinemassacre extractor, I think he changed some of the rtmp urls, so it's normal. It seems we don't get all the rtmpdump messages now, that's great :)

@FiloSottile
Copy link
Collaborator Author

Great, I know what I'm doing this night then! ;)

On Monday, November 25, 2013, Jaime Marquínez Ferrándiz wrote:

rzhxeo did some improvements on the Cinemassacre extractor, I think he
changed some of the rtmp urls, so it's normal. It seems we don't get all
the rtmpdump messages now, that's great :)


Reply to this email directly or view it on GitHubhttps://github.com//pull/1601#issuecomment-29252043
.

Filippo Valsorda

@phihag
Copy link
Contributor

phihag commented Jan 25, 2015

Thanks! Applied to current youtube-dl master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants