-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis test also rtmpdump videos #1601
Conversation
Ok it works but we need to check if it stable and to quiet that stuff down. |
rtmpdump seems to hang indefinitely sometimes |
Umh, a strange line to hang on... |
I think this change is not the cause of the hang, it happens other times. If the checksum are always the same (I have yet to understand why it always download the same piece of data), I'm +1. The only problem is all the noise it produces (maybe #1680 solve this). |
Rebased to re-run, let's see... |
Test worked, Cinemassacre md5 changed, Videopremium stayed. |
rzhxeo did some improvements on the Cinemassacre extractor, I think he changed some of the rtmp urls, so it's normal. It seems we don't get all the rtmpdump messages now, that's great :) |
Great, I know what I'm doing this night then! ;) On Monday, November 25, 2013, Jaime Marquínez Ferrándiz wrote:
Filippo Valsorda |
Thanks! Applied to current youtube-dl master. |
Is there a reason we are not doing this? Maybe we needed #1565
If this works, I'll convert all the
skip_download
tests