[Tvnow] bugfix & download whole serie #15837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstftw
requested changes
Mar 12, 2018
youtube_dl/extractor/tvnow.py
Outdated
| @@ -178,7 +178,47 @@ def _real_extract(self, url): | |||
| if not seo_url: | |||
| continue | |||
| entries.append(self.url_result( | |||
| base_url + seo_url + '/player', 'TVNow', info.get('id'))) | |||
| base_url + seo_url + '/player', 'TVNow', compat_str(info.get('id')))) | |||
youtube_dl/extractor/tvnow.py
Outdated
|
|
||
|
|
||
| class TVNowListChannelIE(TVNowBaseIE): | ||
| _VALID_URL = r'(?P<base_url>https?://(?:www\.)?tvnow\.(?:de|at|ch)/(?:rtl(?:2|plus)?|nitro|superrtl|ntv|vox)/(?P<show_id>[^/]+))$' |
There was a problem hiding this comment.
No trailing $. Override suitable.
youtube_dl/extractor/tvnow.py
Outdated
| base_url + "/list/" + season_url, 'TVNowList', compat_str(season_info.get('id')), season_info.get('headline'))) | ||
|
|
||
| return self.playlist_result( | ||
| entries, compat_str(list_info['id']), compat_str(list_info['title'] or show_id)) |
There was a problem hiding this comment.
Playlist metadata must not be fatal.
youtube_dl/extractor/tvnow.py
Outdated
| 'formats/seo', show_id, query={ | ||
| 'fields': ','.join(fields), | ||
| 'name': show_id + '.php' | ||
| }) |
youtube_dl/extractor/tvnow.py
Outdated
|
|
||
| fields = [] | ||
| fields.extend(self._SHOW_FIELDS) | ||
| fields.extend('formatTabs.%s' % field for field in self._SEASON_FIELDS) |
|
hope now it's like you want it |
dstftw
requested changes
Mar 19, 2018
youtube_dl/extractor/tvnow.py
Outdated
| @@ -178,7 +186,40 @@ def _real_extract(self, url): | |||
| if not seo_url: | |||
| continue | |||
| entries.append(self.url_result( | |||
| base_url + seo_url + '/player', 'TVNow', info.get('id'))) | |||
| base_url + seo_url + '/player', 'TVNow', str(info.get('id')))) | |||
youtube_dl/extractor/tvnow.py
Outdated
|
|
||
|
|
||
| class TVNowListChannelIE(TVNowBaseIE): | ||
| _VALID_URL = r'(?P<base_url>https?://(?:www\.)?tvnow\.(?:de|at|ch)/(?:rtl(?:2|plus)?|nitro|superrtl|ntv|vox)/(?P<show_id>[^/]+)$)' |
There was a problem hiding this comment.
I've already pointed out: no trailing $. Override suitable instead.
youtube_dl/extractor/tvnow.py
Outdated
| 'fields': ','.join(fields), | ||
| 'name': show_id + '.php' | ||
| }) | ||
| fields = self._extend_query(self._SHOW_FIELDS, self._SEASON_FIELDS, self._VIDEO_FIELDS) |
There was a problem hiding this comment.
Code duplication 173, 213. There is no sense to extract fields explicitly.
|
|
||
| return fields | ||
|
|
||
| def _tvnow_list_info(self, list_id, show_id, fields): |
There was a problem hiding this comment.
This is not used in single video extractor thus should not be here.
youtube_dl/extractor/tvnow.py
Outdated
| base_url + "/list/" + season_url, 'TVNowList', compat_str(season_info.get('id')), season_info.get('headline'))) | ||
|
|
||
| return self.playlist_result( | ||
| entries, list_info['id'], list_info['title']) |
There was a problem hiding this comment.
Playlist id and title should not be fatal.
|
anything else? |
dstftw
reviewed
Apr 2, 2018
| entries.append(self.url_result( | ||
| base_url + seo_url + '/player', 'TVNow', info.get('id'))) | ||
| base_url + seo_url + '/player', 'TVNow', str(info.get('id', seo_url)))) |
There was a problem hiding this comment.
One question: do you even read my posts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.
with this pull request you can download a whole serie