[nick] add support for nick austria and nicknight #10769
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstftw
requested changes
Sep 27, 2016
|
|
||
| mrss_url = update_url_query(self._search_regex( | ||
| r'mrss: (["\'])(?P<url>http.+?)\1', webpage, 'mrss url', group='url'), | ||
| {'siteKey': 'nicknight.de'}) |
There was a problem hiding this comment.
Web player does not send this query.
There was a problem hiding this comment.
how can I check which query it sends?
There was a problem hiding this comment.
Network connections in your browser.
There was a problem hiding this comment.
I can't find info on how to look what the web player sends in the browser. Is there an addon I need to install on chrome or Firefox? Or do I have to use wireshark and search the tcp-dump?
I've looked through the downloaded files with curl and I removed the update_url_query call
|
Please review the changes. Hope I got the Point |
NeroBurner
force-pushed
the
nickelodeon_at
branch
from
a453f9f
to
bfda02d
Compare
|
@dstftw could you pls review once more, I rebased the changes on current master |
calbrecht
referenced
this pull request
in calbrecht/youtube-dl
Dec 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requirements
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This pull request adds two improvements