-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maya: Fix Redshift cryptomatte multipartEXR #6240
Maya: Fix Redshift cryptomatte multipartEXR #6240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All working well with multipart EXR
and Cryptomatte
aov...
Here is a scrngrab of JSON with that attrib turned FALSE
The job were finnished successfully and also published fine.
Im also enclosing the JSON for clarification.
renderLookdevMain_metadata.json.txt
Co-authored-by: Roy Nieterau <[email protected]>
@LiborBatek could I get another test of this? |
Co-authored-by: Roy Nieterau <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wish this could've been 'simpler' and 'cleaner' - but the big comment does explain some of the reasoning behind it. I guess it does what it should.
Code changes make sense - didn't test it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re did the testing and all working ok, DL job finnished without any errors, all renders been integrated as well and finally the JSON file contain the multipart: false
flag too...
All goood. good to go IMHO!
Changelog Description
When using Redshift and rendering multipart EXRs, the instances for cryptomatte AOVs are getting falsely marked as multipart EXR even though they are being forced to be separate files by Redshift.
Since we cannot query the AOVs multipart individually, we'll need a hardcoded rule.
Ideally I guess AOVs should be separate instances in the publishing process but that is too big of a scope atm.
Testing notes:
"multipartExr": true
in the metadata json.