Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Delivery in library loader #1546

Merged
merged 12 commits into from
May 25, 2021
Merged

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented May 20, 2021

Selected subsets and their versions could be exported via context menu with a use of predefined Delivery template.

Delivery Action from FTrack was bit refactored, needs to be retested!

Closes https://github.com/pypeclub/client/issues/68
Requires:
ynput/avalon-core#339

Extracted methods from existing Delivery Action on FTrack
Fixed Delivery Action for sequences
@kalisp kalisp added the type: enhancement Enhancements to existing functionality label May 20, 2021
@kalisp kalisp requested a review from mkolar May 20, 2021 14:04
@kalisp kalisp self-assigned this May 20, 2021
@mkolar
Copy link
Member

mkolar commented May 20, 2021

works well.

@kalisp kalisp added the sponsored Client endorsed or requested label May 21, 2021
@mkolar mkolar requested review from mkolar and a team May 24, 2021 06:19
@mkolar mkolar added this to the 2.18.1 milestone May 24, 2021
openpype/lib/delivery.py Outdated Show resolved Hide resolved
openpype/lib/delivery.py Outdated Show resolved Hide resolved
@iLLiCiTiT
Copy link
Member

Ideas about dialog:

  • why is there so much space in between representations and button?
    • representation inputs should be a part of a widget instead of only layout to prevent widgets be squeezed
  • "Deliver" button should be stretched to right side (it's a big button)
    • I would also add "Cancel" or "Close" button?
    • if not then "Deliver" button should change to "Close" as it seems like it has no reason of existence after delivery
  • template value makes the dialog a lot bigger
    • I thought that it may be better to not show whole template but ellided text with tooltip showing full template?

image
image

Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me

Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I missed it before, but this now doesn't work with sequences at all. I only get one frame.

import clique
import collections

def collect_frames(files):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected 2 blank lines, found 1

@kalisp
Copy link
Member Author

kalisp commented May 25, 2021

Fixed, change of logic broke it. Same issue in 2.x though :/.

@kalisp kalisp requested a review from mkolar May 25, 2021 16:22
@mkolar mkolar merged commit 095525d into develop May 25, 2021
@mkolar mkolar deleted the feature/delivery_in_library_loader branch May 25, 2021 19:20
@mkolar mkolar removed this from the 2.18.1 milestone Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sponsored Client endorsed or requested type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants