-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable include
rule in php-cs-fixer
#14418
Conversation
heredoc_to_nowdoc
in php-cs-fixerinclude
rule in php-cs-fixer
Please resolve conflicts. Thanks. |
# Conflicts: # framework/console/Application.php # framework/rbac/PhpManager.php # framework/test/ActiveFixture.php # framework/test/ArrayFixture.php # framework/test/BaseActiveFixture.php
Done. |
Merged. Thanks! |
@@ -97,7 +97,7 @@ configuration file for the [Basic Project Template](start-installation.md). | |||
$config = [ | |||
'id' => 'basic', | |||
'basePath' => dirname(__DIR__), | |||
'extensions' => require(__DIR__ . '/../vendor/yiisoft/extensions.php'), | |||
'extensions' => require __DIR__ . '/../vendor/yiisoft/extensions.php', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imo the function syntax is easier to read in cases where require
is used to return something...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine either way. Less characters — less noise.
Continuation of #14100
See https://github.com/FriendsOfPHP/PHP-CS-Fixer
Refs yiisoft/yii2-app-basic#123