Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deriving of Typeable. #1114

Merged
merged 1 commit into from
Aug 23, 2020
Merged

Remove deriving of Typeable. #1114

merged 1 commit into from
Aug 23, 2020

Conversation

kukimik
Copy link
Contributor

@kukimik kukimik commented Aug 19, 2020

Closes #1107.

I am not sure about the use of Typeable in persistent-template/Database/Persist/TH.hs. However, even if it is no longer needed, this may be out of scope for this PR. After some research I believe this is handled by Template Haskell, as it should be.

I hope I got the versions/changelogs right.


After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@MaxGabriel
Copy link
Member

This looks great to me, thanks!

@MaxGabriel MaxGabriel merged commit 7f4abe9 into yesodweb:master Aug 23, 2020
@MaxGabriel
Copy link
Member

Ok, I released persistent-mongoDB-2.10.0.1. I'm not a maintainer of persistent-redis or persistent-test. @parsonsmatt any chance you could add me for those?

@kukimik kukimik deleted the remove_deriving_typeable branch August 24, 2020 12:37
@parsonsmatt
Copy link
Collaborator

@MaxGabriel You're on for persistent-test.

persistent-redis is maintained by @paulrzcz

@parsonsmatt
Copy link
Collaborator

It looks like @psibi uploaded recently, so could probably add to the Hackage repo

@psibi
Copy link
Member

psibi commented Aug 24, 2020

@MaxGabriel / @parsonsmatt Added both of you to the Hackage repo.

@MaxGabriel
Copy link
Member

Thanks, I released and tagged persistent-redis and persistent-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unnecessary deriving of Typeable
4 participants