Sanitize csv strings #258
Merged
Sanitize csv strings #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs to be fixed and thanks for the contribution! I think I would prefer splitting on , first, and then calling https://pkg.go.dev/strings#TrimSpace on the elements. I might come back to this soon, I'd like this to be fixed 🙇 |
yannh
approved these changes
May 9, 2024
|
Merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a simple fix to #256
Two additional test cases were implemented to check some cases of possible input value patterns.
The fix itself is realized within the splitCSV function, which now by default replaces all " " by "".
I'm aware, that this might not be the most suitable place for this fix.
I thought of implementing it in one of the higher level function but was not sure about implications.
Feel free to comment of course :)