Simplify run methods #119
Merged
Simplify run methods #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting circuitbox_exceptions to false. In this case the new run method would act like the old run method, returning nil if these errors would have been encountered.
…n exception after we've store the response. This becomes a problem if if the exception that is raised is one that circuitbox is tracking. If circuitbox_exceptions is false and this were to happen the response would be the return value of the block. This keeps the behavior of the previous implementation of run.
matthewshafer
force-pushed
the
simplify-run-methods
branch
from
0d7625a
to
fbf52f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Circuitbox's
runmethod rescues exceptions to return nil. Raising / rescuing these exceptions to return nil is pretty expensive. By switching run to take the keyword argcircuitbox_exceptionswe don't need to raise exceptions just to return nil on failure.This is a breaking change, but this is going in with a major version bump.