Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up undefined instance variable warnings #103

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Cleaned up undefined instance variable warnings #103

merged 1 commit into from
Jun 14, 2018

Conversation

philsturgeon
Copy link

Unit test output was hard to read, had a lot of warnings in it. This
code is functionally the same but doesn't trigger those warnings. :)


/Users/psturgeon/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/moneta-1.0.0/lib/moneta/expires.rb:31:
warning: assigned but unused variable - expires
................../Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:69:
warning: instance variable @circuit_breaker_options not initialized
./Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:69:
warning: instance variable @circuit_breaker_options not initialized
/Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:78:
warning: instance variable @default_value not initialized
./Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:69:
warning: instance variable @circuit_breaker_options not initialized
./Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:69:
warning: instance variable @circuit_breaker_options not initialized
/Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:78:
warning: instance variable @default_value not initialized
./Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:69:
warning: instance variable @circuit_breaker_options not initialized
/Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:78:
warning: instance variable @default_value not initialized
./Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:69:
warning: instance variable @circuit_breaker_options not initialized
./Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:69:
warning: instance variable @circuit_breaker_options not initialized
/Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:78:
warning: instance variable @default_value not initialized
./Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:69:
warning: instance variable @circuit_breaker_options not initialized
./Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:69:
warning: instance variable @circuit_breaker_options not initialized
/Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:78:
warning: instance variable @default_value not initialized
./Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:69:
warning: instance variable @circuit_breaker_options not initialized
/Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:78:
warning: instance variable @default_value not initialized
./Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:69:
warning: instance variable @circuit_breaker_options not initialized
../Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:69:
warning: instance variable @circuit_breaker_options not initialized
./Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:69:
warning: instance variable @circuit_breaker_options not initialized
../Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:69:
warning: instance variable @circuit_breaker_options not initialized
...../Users/psturgeon/src/circuitbox/lib/circuitbox/excon_middleware.rb:89:
warning: instance variable @circuit_breaker_options not initialized
E/Users/psturgeon/src/circuitbox/lib/circuitbox/excon_middleware.rb:89:
warning: instance variable @circuit_breaker_options not initialized
E/Users/psturgeon/src/circuitbox/lib/circuitbox/excon_middleware.rb:89:
warning: instance variable @circuit_breaker_options not initialized
E./Users/psturgeon/src/circuitbox/lib/circuitbox/excon_middleware.rb:89:
warning: instance variable @circuit_breaker_options not initialized
E./Users/psturgeon/src/circuitbox/lib/circuitbox/excon_middleware.rb:89:
warning: instance variable @circuit_breaker_options not initialized
E/Users/psturgeon/src/circuitbox/lib/circuitbox/excon_middleware.rb:89:
warning: instance variable @circuit_breaker_options not initialized
E/Users/psturgeon/src/circuitbox/lib/circuitbox/excon_middleware.rb:89:
warning: instance variable @circuit_breaker_options not initialized
E/Users/psturgeon/src/circuitbox/lib/circuitbox/excon_middleware.rb:89:
warning: instance variable @circuit_breaker_options not initialized
E/Users/psturgeon/src/circuitbox/lib/circuitbox/excon_middleware.rb:89:
warning: instance variable @circuit_breaker_options not initialized
E/Users/psturgeon/src/circuitbox/lib/circuitbox/excon_middleware.rb:89:
warning: instance variable @circuit_breaker_options not initialized
E.....................................

Finished in 0.070928s, 1226.5960 runs/s, 1494.4733 assertions/s.

Unit test output was hard to read, had a lot of warnings in it. This
code is functionally the same but doesn't trigger those warnings. :)

```

/Users/psturgeon/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/moneta-1.0.0/lib/moneta/expires.rb:31:
warning: assigned but unused variable - expires
................../Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:69:
warning: instance variable @circuit_breaker_options not initialized
./Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:69:
warning: instance variable @circuit_breaker_options not initialized
/Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:78:
warning: instance variable @default_value not initialized
./Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:69:
warning: instance variable @circuit_breaker_options not initialized
./Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:69:
warning: instance variable @circuit_breaker_options not initialized
/Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:78:
warning: instance variable @default_value not initialized
./Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:69:
warning: instance variable @circuit_breaker_options not initialized
/Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:78:
warning: instance variable @default_value not initialized
./Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:69:
warning: instance variable @circuit_breaker_options not initialized
./Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:69:
warning: instance variable @circuit_breaker_options not initialized
/Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:78:
warning: instance variable @default_value not initialized
./Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:69:
warning: instance variable @circuit_breaker_options not initialized
./Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:69:
warning: instance variable @circuit_breaker_options not initialized
/Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:78:
warning: instance variable @default_value not initialized
./Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:69:
warning: instance variable @circuit_breaker_options not initialized
/Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:78:
warning: instance variable @default_value not initialized
./Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:69:
warning: instance variable @circuit_breaker_options not initialized
../Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:69:
warning: instance variable @circuit_breaker_options not initialized
./Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:69:
warning: instance variable @circuit_breaker_options not initialized
../Users/psturgeon/src/circuitbox/lib/circuitbox/faraday_middleware.rb:69:
warning: instance variable @circuit_breaker_options not initialized
...../Users/psturgeon/src/circuitbox/lib/circuitbox/excon_middleware.rb:89:
warning: instance variable @circuit_breaker_options not initialized
E/Users/psturgeon/src/circuitbox/lib/circuitbox/excon_middleware.rb:89:
warning: instance variable @circuit_breaker_options not initialized
E/Users/psturgeon/src/circuitbox/lib/circuitbox/excon_middleware.rb:89:
warning: instance variable @circuit_breaker_options not initialized
E./Users/psturgeon/src/circuitbox/lib/circuitbox/excon_middleware.rb:89:
warning: instance variable @circuit_breaker_options not initialized
E./Users/psturgeon/src/circuitbox/lib/circuitbox/excon_middleware.rb:89:
warning: instance variable @circuit_breaker_options not initialized
E/Users/psturgeon/src/circuitbox/lib/circuitbox/excon_middleware.rb:89:
warning: instance variable @circuit_breaker_options not initialized
E/Users/psturgeon/src/circuitbox/lib/circuitbox/excon_middleware.rb:89:
warning: instance variable @circuit_breaker_options not initialized
E/Users/psturgeon/src/circuitbox/lib/circuitbox/excon_middleware.rb:89:
warning: instance variable @circuit_breaker_options not initialized
E/Users/psturgeon/src/circuitbox/lib/circuitbox/excon_middleware.rb:89:
warning: instance variable @circuit_breaker_options not initialized
E/Users/psturgeon/src/circuitbox/lib/circuitbox/excon_middleware.rb:89:
warning: instance variable @circuit_breaker_options not initialized
E.....................................

Finished in 0.070928s, 1226.5960 runs/s, 1494.4733 assertions/s.
```
Copy link
Collaborator

@matthewshafer matthewshafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @philsturgeon, now the test output is a bit easier to read.

@matthewshafer matthewshafer merged commit 7f1bba7 into yammer:master Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants