Skip to content

Commit

Permalink
bpo-38899: virtual environment activation for fish should use source (
Browse files Browse the repository at this point in the history
pythonGH-17359)

The previously documented use of `.` is considered deprecated (https://fishshell.com/docs/current/commands.html#source).


https://bugs.python.org/issue38899



Automerge-Triggered-By: @brettcannon
  • Loading branch information
brettcannon authored and miss-islington committed Nov 23, 2019
1 parent d68b592 commit 84b1ff6
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Doc/using/venv-create.inc
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ directory containing the virtual environment):
+=============+=================+=========================================+
| POSIX | bash/zsh | $ source <venv>/bin/activate |
+-------------+-----------------+-----------------------------------------+
| | fish | $ . <venv>/bin/activate.fish |
| | fish | $ source <venv>/bin/activate.fish |
+-------------+-----------------+-----------------------------------------+
| | csh/tcsh | $ source <venv>/bin/activate.csh |
+-------------+-----------------+-----------------------------------------+
Expand Down
4 changes: 2 additions & 2 deletions Lib/venv/scripts/posix/activate.fish
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# This file must be used with ". bin/activate.fish" *from fish* (http://fishshell.org);
# you cannot run it directly.
# This file must be used with "source <venv>/bin/activate.fish" *from fish*
# (http://fishshell.org); you cannot run it directly.

function deactivate -d "Exit virtualenv and return to normal shell environment"
# reset old environment variables
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Update documentation to state that to activate virtual environments under
fish one should use `source`, not `.` as documented at
https://fishshell.com/docs/current/commands.html#source.

0 comments on commit 84b1ff6

Please sign in to comment.