bpo-38823: Fix refleak in marshal init error path (pythonGH-17260)

xzy3 · Nov 20, 2019 · 33b671e · 33b671e
1 parent 2e96906
commit 33b671e
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/Python/marshal.c b/Python/marshal.c
@@ -1829,6 +1829,9 @@ PyMarshal_Init(void)
     PyObject *mod = PyModule_Create(&marshalmodule);
     if (mod == NULL)
         return NULL;
-    PyModule_AddIntConstant(mod, "version", Py_MARSHAL_VERSION);
+    if (PyModule_AddIntConstant(mod, "version", Py_MARSHAL_VERSION) < 0) {
+        Py_DECREF(mod);
+        return NULL;
+    }
     return mod;
 }