Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epub: fix send-to-kindle failure on notes.html #419

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

chen-charles
Copy link
Contributor

@chen-charles chen-charles commented Aug 27, 2024

Kindle Previewer indicates the following error,

"Type","Description"
"Error","E1005: Could not access file. in file: <path>\OEBPS\notes.html","","","",""
"Status","Book conversion failed."

Calibre editor points to the same issue,
image

This PR,

  1. excludes notes.html reference if data.notes is not valid
  2. fixes compile on case-sensitive fs (e.g., ubuntu)
  3. fixes prettier having trouble with \\ on unix fs
  4. pins @types/har-format to 1.2.8: typescript 3.9.10 does not compile with newer har-format

@xuejianxianzun xuejianxianzun merged commit 64a5331 into xuejianxianzun:master Aug 28, 2024
@xuejianxianzun
Copy link
Owner

Thanks! I've submitted a new version with this update and it's under review now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants