Make it so CMake now grabs the latest dr_wav version instead of 0.8.1 #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a soundtest feature. It can be enabled by defining ENABLE_SOUNDTEST when running cmake. For example: 'cmake .. -DENABLE_SOUNDTEST=1' A new entry will appear in settings and it can be used to access the soundtest menu. The number represents the sound id, and you can change the current sound using the arrows. Clicking on 'play' plays the selected sound. This feature is useful when testing if all sounds are read, loaded and played correctly, specially useful for checking if dr_wav works correctly after an update. It also prints the name of the sound to the console when it plays. At the time of this commit, there are currently 40 sounds in total loaded and used by BetterSpades. If more sounds are added, the soundtest.c file must be modified to add new entries. Perhaps this could be improved in the future to allow automatic detection/loading of sounds, without having to manually add entries to the soundtest.c file.
hourai-dev
force-pushed
the
dr_wav-version
branch
from
a4340f9
to
0e8a2e1
Compare
|
I implemented a new soundtest feature in the latest commit. It can be enabled by defining |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made it so CMake now grabs the latest dr_wav version instead of 0.8.1, and changed sound.c so it is now compatible with the new API introduced in 0.9.0. This shouldn't not be a problem unless the API changes again. I tested it with the latest version and it works correctly. Is there any specific reason as to why it uses dr_wav 0.8.1?
Also, I am running Fedora 32 with GCC version 10.0.1 (Red Hat 10.0.1-0.11), GNU make version 4.2.1 and cmake version 3.17.2, and I ran into an error when building the project. When building utils.c, the build terminates with "unknown type name 'size_t'". I simply just made it so that utils.h includes stddef.h (which includes the definition for size_t), which fixes the errors and makes it so that the project builds fine.