Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hevc config version to be 0 or 1 #153

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Allow hevc config version to be 0 or 1 #153

merged 2 commits into from
Mar 28, 2024

Conversation

dexbol
Copy link
Contributor

@dexbol dexbol commented Dec 23, 2023

No description provided.

@xqq
Copy link
Owner

xqq commented Dec 23, 2023

If you are handling version 0, you'd better limit the configurationVersion to be 0 or 1, rather than not checking

Like this
https://chromium.googlesource.com/chromium/src/media/+/master/formats/mp4/hevc.cc#167

@dexbol dexbol changed the title Ignore hevc configurationVersion checking Allow hevc config version to be 0 or 1 Dec 23, 2023
@xqq xqq merged commit fc7a272 into xqq:master Mar 28, 2024
@xqq
Copy link
Owner

xqq commented Mar 28, 2024

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants