Issue openai#243 - Invalid action space for DoomDeathmatch-v0 (openai…

…#245)
xqding · Jul 19, 2016 · 466da84 · 466da84
1 parent 4be4b15
commit 466da84
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/gym/envs/doom/assets/deathmatch.cfg b/gym/envs/doom/assets/deathmatch.cfg
@@ -17,6 +17,7 @@ episode_start_time = 0
 episode_timeout = 6300
 
 # Available buttons
+# Currently disabled:         [33] - DROP_SELECTED_WEAPON
 available_buttons =
     {
         ATTACK
@@ -57,7 +58,6 @@ available_buttons =
 
         SELECT_NEXT_WEAPON
         SELECT_PREV_WEAPON
-        DROP_SELECTED_WEAPON
 
         ACTIVATE_SELECTED_WEAPON
         SELECT_NEXT_ITEM

diff --git a/gym/envs/doom/doom_deathmatch.py b/gym/envs/doom/doom_deathmatch.py
@@ -36,6 +36,9 @@ class DoomDeathmatchEnv(doom_env.DoomEnv):
         [...]
         actions[42] = 0      # MOVE_UP_DOWN_DELTA
         A full list of possible actions is available in controls.md
+
+    Note:
+        actions[33] (DROP_SELECTED_WEAPON) is currently disabled, because it causes VizDoom to crash
     -----------------------------------------------------
     """
     def __init__(self):

diff --git a/gym/envs/doom/doom_env.py b/gym/envs/doom/doom_env.py
@@ -38,7 +38,7 @@
     ['my_way_home.cfg', 'my_way_home.wad', '', 5, [13, 14, 15], -0.22, 0.5],                     # 5 - MyWayHome
     ['predict_position.cfg', 'predict_position.wad', 'map01', 3, [0, 14, 15], -0.075, 0.5],      # 6 - PredictPosition
     ['take_cover.cfg', 'take_cover.wad', 'map01', 5, [10, 11], 0, 750],                          # 7 - TakeCover
-    ['deathmatch.cfg', 'deathmatch.wad', '', 5, list(range(NUM_ACTIONS)), 0, 20]                 # 8 - Deathmatch
+    ['deathmatch.cfg', 'deathmatch.wad', '', 5, [x for x in range(NUM_ACTIONS) if x != 33], 0, 20] # 8 - Deathmatch
 ]