Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SliderRow Layout problem #1296

Merged
merged 5 commits into from
Feb 28, 2018

Conversation

akabab
Copy link
Contributor

@akabab akabab commented Oct 24, 2017

Changes the SliderRow's layout constraints to fit a 44pt cell, correctly aligned & centred.
Plus: valueLabel is now visible even if no title provided.

Before After

This fixes #324

@mtnbarreto
Copy link
Member

Hi @akabab , It would be great if we have the ability to show or not the value label. Could you implement it?

sometimes we want just to show the slider bar since the value doesn't matter or is shown in another view.

@cerupcat
Copy link

cerupcat commented Dec 27, 2017

This only appears to fix this by putting the slider and text on the same line and doesn't allow for not showing a valueLabel. What if we want the current solution (where the slider is under), but also fix the current bug?

@mtnbarreto mtnbarreto mentioned this pull request Jan 9, 2018
@m-revetria
Copy link
Member

@cerupcat, please check this #1316 (comment)

@lukeleleh
Copy link

Any update for SliderRow's UI Bug?

@akabab
Copy link
Contributor Author

akabab commented Feb 7, 2018

@mtnbarreto Hey, sorry for the late reply. I've done small adds to show/hide the value label

@mtnbarreto
Copy link
Member

Hi @akabab ! thanks for contributing!

@mtnbarreto mtnbarreto merged commit ad6ea31 into xmartlabs:master Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SliderRow layout problem on iPhone5s/4s
5 participants