Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pre-release of version 2.1.0-alpha.15 #657

Merged
merged 2 commits into from
Dec 21, 2022
Merged

Conversation

guergana
Copy link
Contributor

No description provided.

@github-actions
Copy link

Copy link
Member

@lucaswerkmeister lucaswerkmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add the changes to the CHANGELOG.md too – something like:

Let Lookup attributes fall through to <input>
Fix Lookup navigation on arrow down

@guergana
Copy link
Contributor Author

guergana commented Dec 21, 2022

I think we should add the changes to the CHANGELOG.md too – something like:

Let Lookup attributes fall through to <input>
Fix Lookup navigation on arrow down

I thought changelog updates were not necessary for pre-releases. This from the docs:

Note: there is no need to describe the changes, as this is simply a pre release.

Or does this apply only when creating the release on GitHub?

@lucaswerkmeister
Copy link
Member

Hm, then the docs don’t seem to match our current practice 😅 I noticed this based on the changes in earlier pre-releases (e.g. 1d8da10, 533965b); I also think it can help to collect the changes earlier, so we don’t have as much work to do when we make the final release?

@guergana
Copy link
Contributor Author

guergana commented Dec 21, 2022

Hm, then the docs don’t seem to match our current practice 😅 I noticed this based on the changes in earlier pre-releases (e.g. 1d8da10, 533965b); I also think it can help to collect the changes earlier, so we don’t have as much work to do when we make the final release?

I probably never added a release change before when making a prerelease. I have made a few. I don't think it's a common practice to add a change release. We probably need to discuss that line in the docs with the team so it's clear.

@guergana guergana merged commit df11986 into master Dec 21, 2022
@guergana guergana deleted the prerelease-bug-fix branch December 21, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants