Skip to content
This repository has been archived by the owner on Aug 28, 2023. It is now read-only.

add archlinux build #73

Merged
merged 6 commits into from
Jul 21, 2020
Merged

add archlinux build #73

merged 6 commits into from
Jul 21, 2020

Conversation

palytoxin
Copy link
Contributor

I'm trying to create archlinux build

Copy link
Member

@ashkulz ashkulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@palytoxin: thanks for the contribution, appreciate your trying to make a build.

You should always test the PR by running ./build package-docker archlinux-amd64 WKHTMLTOPDF-SRC-DIR and testing that the generated package works on your machine.

build.yml Show resolved Hide resolved
docker/Dockerfile.archlinux Outdated Show resolved Hide resolved
@palytoxin
Copy link
Contributor Author

palytoxin commented Jul 17, 2020

I was add gcc7 and pacman build config. and test compile-docker package-docker passed in my machine.
Please correct me if there is any mistake

pacman pkg have some problem

@palytoxin palytoxin changed the title add archlinux build [WIP]add archlinux build Jul 18, 2020
Copy link
Member

@ashkulz ashkulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Were you able to install the packages? I got an error in a clean docker environment:

error: failed to commit transaction (conflicting files)
wkhtmltox: /usr/local/share/man exists in filesystem (owned by filesystem)
Errors occurred, no packages were upgraded.

I don't use ArchLinux, don't know if you can still proceed with this?

@palytoxin
Copy link
Contributor Author

palytoxin commented Jul 19, 2020

I will test and fix it, well, it may take some time

I have a problem, the config prefix path is /usr/local, but it's not standards path in archlinux, /usr is valid.
I create a dup config section for prefix. It seems to be redundancy. ennnn.. how can I fix it?

@dockerlead
Copy link

@ashkulz Can you merge this pr if it works fine?

build Show resolved Hide resolved
@palytoxin palytoxin changed the title [WIP]add archlinux build add archlinux build Jul 21, 2020
@palytoxin palytoxin requested a review from ashkulz July 21, 2020 03:32
Copy link
Member

@ashkulz ashkulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ashkulz ashkulz merged commit a9fcfff into wkhtmltopdf:master Jul 21, 2020
@ashkulz
Copy link
Member

ashkulz commented Jul 21, 2020

Thanks for the contribution, @palytoxin!

ashkulz added a commit to wkhtmltopdf/wkhtmltopdf that referenced this pull request Jul 22, 2020
@ashkulz
Copy link
Member

ashkulz commented Jul 22, 2020

Added to the downloads page 🎉

@ashkulz
Copy link
Member

ashkulz commented Jul 22, 2020

@foutrelis you might want to use this package in wkhtmltopdf-static, not sure how it can be used directly 🤷‍♂️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants