[EJBCLIENT-254] Fix bug where JBossEJBProperties.class.getClassLoader() returned null #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be much better to handle null properly than to fall back to a random, other classloader. Normally we never want to mix classloader acquisition strategies. In addition, the TCCO may be null anyway. |
|
Well, in that case a default 'jboss-ejb-client.properties' inside the jar would not be found, as we wouldn't have a ClassLoader... |
|
You do have a class loader. "Null" just means you have to use ClassLoader.getSystemResource() etc. instead. |
|
Take a look at #301 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately I was not able to provide an automated unittest for this fix, but the Jira issue itself contains the procedure steps to reproduce it...